Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

A FAQ accordion

Caelus•520
@Caelus111
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

This one is kinda tricky, because I had to search how to do it and then do it my way because I built the html differently than other tutorials.

Next time, I would like to build it myself with my own way of thinking

What challenges did you encounter, and how did you overcome them?

i was originaly gonna do everything with js, but that was the hardest way because of the way I built the html, so I did some changes in the UI in css and the dislay changed in JS which was the easiest way to do it

What specific areas of your project would you like help with?

It's not perfect so If you have a better way tell me!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Alex•3,130
    @Alex-Archer-I
    Posted about 1 year ago

    Hi!

    There no need in this work to use header and nav tags. Those tags have a specific semantic meanings - they represent a top part of the site which is the same for all it's pages. nav in turn should contain navigation menu and nothing else. This project doesn't have all that =)

    And that is why header and main should be a sibling tags.

    The box-shadow property have a very wide browser support now - more than 98%. So, you don't have to add vendor prefix for it.

    Oh, and you have a few extra constants in your code. Guess you planned more complex algorithm initially =)

    Overall you've done quite a neat work, keep doing =)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub