A little bit of CSS magic, a pinch of JS and dash of API.

Community feedback

• 

  P

  Dave•5,295

  @dwhenson

  Posted almost 3 years ago

  Lovely job here. The app works well 🙌

  I would just suggest in your JS to add a check to ensure the API has responded correctly and render an error message if not. This isn't too tricky, and I would just change the first then to be something like:

    .then(response => response.ok ? response.json() : Promise.reject("API failed")```
  

  If you then add a catch at the end of your fetch function you can render some fallback text in case things don't work for any reason.

  It's not a big deal, but thinking about how things can go wrong is a good habit to get into.

  Cheers 👋

  Dave

  10

  Marked as helpful
• 

  Emanuele Gurini•140

  @emanuelegurini

  Posted almost 3 years ago

  Hi Gareth, seems that Firefox is caching the fetch result. I found this solution on StackOverflow (https://stackoverflow.com/questions/72567690/ui-is-not-updating-on-click-event-that-triggers-a-fetch-on-firefox-developer) but the problem is that property called count is always incremented by one, and, if you start a new session, advice is always the same in a row.

  To avoid the same advice in a row, as you can see from my solution, I create a new Random number, and I use it only if my script detects firefox browser.

  My solution: https://github.com/EmanueleGurini/js-advicegenerator/blob/master/js/main.js

  ps. why am I using 224 as max number? Advices are 224.

  02

  Marked as helpful