A QR-Code Using HTML and CSS

Community feedback

• 

  Owolabi Muktar•20

  @CallmeMukty

  Posted over 2 years ago

  Hi Vanza, thanks for taking time to review the code some of the corrections have been made but, I'm finding it hard to understand how I can apply the ARIA landmark in this particular project. Then I also find the correction you pointed out on padding a bit confusing. Please help review, thank you.

  00
• 

  Vanza Setia•27,715

  @vanzasetia

  Posted over 2 years ago

  Hello, Owolabi! 👋

  Congratulations on finishing this challenge! 👏

  First, I recommend formatting the code. I suggest using Prettier. Formatted code helps people to read and understand your code.

  I have some feedback on this solution.

  • The QR code is the main content of the website. It should have alternative text to make it gets pronounced by screen readers.
  • Make the first paragraph a h1. Keep in mind that every page must have one h1.
  • Remove overflow-y: hidden; from the body element. On mobile landscape view where the card needs more than the viewport height of the screen, the users can't scroll.
  • Set padding on the card element to prevent the content from touching the corner of the card. Then, remove the horizontal padding or margin from the elements inside the card.

  I hope this helps!

  P.S. I saw your tweet and you were asking for feedback. Next time, I recommend asking for feedback here by adding specific questions to the "Questions for the community" textarea. Or tells about the part that you struggle. This will give your solution higher chance to get feedback.

  00