@elaineleung
Posted
Hi Kellen, your solution looks really good, and well done in making it look very close to the design!
I think the only suggestion I have is just to add cursor: pointer
on the "daily", "weekly", and "monthly" so that users know for sure that those are clickable. I also had a look at your code; I feel there are parts where you don't need to keep repeating, such as the timeframeText
object, which I think you can just declare once at the top and use it over again. I also used an object like that, and you can check out my code here to see how I did it.
Well done overall 😊
Marked as helpful
@rule-kells
Posted
@elaineleung Thanks for your feedback! You are right! I forgot the add the cursor: pointer
. And I took a look at your code, and I like how neat it is. I need to write cleaner code. Again, I appreciate your feedback.