Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

Accordion Card using SASS and JS

sass/scss
NadiaFr•310
@NadiaFrShLm
A solution to the FAQ accordion card challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I strugled with this chalenge a lot: first I challenged myself to study sass, and as a result this is my first sass project.

And secondly that was a headache to place all 3 images with corect dimention and position. The problematic was how to make one (box) overlaping the card and main image with pattern put inside the container.

Thirdly, SASS questions: do I need apply sass architecture on such a little project or just 1-2 files would be enough (just a layout and the other components). And should I put the sass folder in .gitignore file as far as style.css already compiled

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jinju Dixon•120
    @PerleMedia
    Posted about 3 years ago

    Hi Nadiafr,

    The project looks great, especially for your first time using SASS. Keep it up, you're doing awesome!

    The first column in your .card div (.img-box) is responsive--if you made that column a fixed width (maybe 400px on desktop?) it could be much easier to place the box svg and make sure it stays in the correct place, as the background image would then remain a single size. Rather than a responsive column, a fixed-width column that changes width based on device breakpoints might save you some headache in positioning!

    As for the SASS architecture, personally I only create as many SASS files as I need to use: for a site like this that may be 1-2, as you said. It's really up to you whether you want to include it in a .gitignore--personally I leave them in, along with a source map so that I can easily inspect the code on a live site and have it correspond to the SASS files instead of the compiled CSS.

    Also, adding a little bit of JS or CSS to animate the accordion as it opens and closes would be a lovely finishing touch!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub