Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Activity Dashboard with Grid

bem, sass/scss, gulp
Dragosh Gheceanu•140
@dragoshcode
A solution to the Time tracking dashboard challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello, any suggestions and feedback is very welcomed since I spent 4 days on this project I had a lot of problems with positioning the layout on card with transform property Could you please check my code and tell me where I could improve and where I'm using some bad practices as well? What would you use to align the two parts of the cards(like the orange, blue, pink etc.) to be as in the design, I've struggle a lot with it and I know I used a very bad practice just to get it done already! Please help me improve :) Thanks

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Raymart Pamplona•16,040
    @pikapikamart
    Posted over 3 years ago

    Hey, really nice work on this one. The desktop layout looks really great, the site is responsive as well and I like that layout when you go tablet size, looks really nice to be honest. Mobile state looks great as well.

    Here are some suggestions for the site:

    • For this one, you should replace the article tag into using main tag since a main tag is needed for a page so that it will be easy for user to know the main-content since they could just traverse the landmark.
    • Inside the .grid selector, you could change each section to just div. section tag is not that informative as landmark element unless you use aria-labelledby on it so that screen-reader will read an extra information about the landmark. div would be fine since traversing by the heading tag is the same when you just use a plain section tag.
    • I noticed that each of the .card selector has a small height, you can see that if you hover when inspecting the layout. For this one, the height is not really needed on each .card. What you can do is that, each icon on the top part of the .card could just be used as background-image for each .card selector, this way you could just add a padding-top on it to simulate the dark-ish container below it to be pushed below.
    • If you insist on using img tag, then use alt="" and add aria-hidden="true" on it since it is only a decorative image.
    • Since you used button on the 3 dots, you should have either aria-label attribute or sr-only text inside it which defines what the button does.
    • The 3 dots img is decorative as well, hide it using the method above.
    • Do not remove the outline styling. If you did, always include a visual-indicator on the :focus-visible for those interactive elements like the button a tag and others.
    • Since you are using a button tag on this one, you could use a ul tag to wrap those button since those are "list" of selections.
    • Also, since button alone is not informative specially when a user toggles it using a screen-reader, you should have used either an aria-live element that will announce whether a specific button has been toggled. Another approach would be to use something like aria-pressed on each button, you set the attribute to true if a button is pressed and for others as well.
    • Lastly, the .attribution should be using a footer tag so that it will be its own landmark element.

    Aside from those, great job again on this one.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub