Adaptive grid

Community feedback

• 

  tmykkanen•140

  @tmykkanen

  Posted 3 months ago

  Nice work on the project!

  • FYI, you've got an error in your readme that's preventing it from rendering in markdown on github. I suspect it's the extra # heading at the end of the file, but I'm not sure.
  • You missed the colored borders on the design brief.
  • You can select which fonts to include from the google font api embed, that way you're not asking the site to load what you don't need.
  • I noticed you used an h3 for the summary of the testimonial. Not great semantic practice. Put an h1 on the page with an overall title and use tailwinds srhidden class to hide it. Then use h2 for your next headings. I'd suggest wrapping the name of the person in h2, since semantically that's the overall heading for the card (even though what's visually emphasized is the testimonial summary. See this css-tricks article for more info.
  • Better to wrap everything in a main than a div.

  00