Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator App

#react

@khalil227

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

Zineb Boutaa• 750

@zineb-Bou

Posted

Hi there, Good job on this challenge I would love to drop some comments that may help you to improve your coding skills even further

  1. Choose the right HTML semantic element, you have chosen only <div> to most of your elements, for instance instead of using a <div> for the dice button use a <button> because it’s an interactive element.
  2. When scaling down to small screens the pattern divider is not fitting anymore within the advice container try to fix that and make it more responsive.
  3. It is better to give your solutions an <h1> every website need to have an <h1> title, in this case, it is a bit subtler, so you can choose <h1> Advice generator</h1> then make it sr-only (screen reader only ) since there is no <h1> in the design .

Good luck

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord