Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice generator app 🎯

#accessibility#sass/scss#webpack
Alaminβ€’ 1,960

@CodePapa360

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


❀️It was enjoyable working on this project. If you have any thoughts on how I could improve my codes, please feel free to share. Thanks! 😊

Community feedback

Abdul Khalid πŸš€β€’ 72,160

@0xabdulkhalid

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.
  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states
  • You already using Flexbox for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.
body {
justify-content-center;
align-items: center;
}

footer {
position: fixed;
bottom: 1rem;
}
  • We additionally placed used fixed positioning for the footer to place that in the bottom of the site properly.
  • Now remove these styles, after removing you can able to see the changes
main {
margin: auto auto 0;
}
.footer {
margin-top: auto;
}
  • Now your components has been properly placed at the right position.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

Alaminβ€’ 1,960

@CodePapa360

Posted

@0xAbdulKhalid Thanks, I'll check that soon 😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord