Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

advice Generator App built with React Js

#react
Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


having Issues with the mobile layout of the app. your comment on the code will greatly be appreciated.

Community feedback

P

@12Kentos

Posted

Hey @obinneji,

Nice job on this project, it looks great! I looked through your code and noticed for the mobile section you added the following code to your media query.

height: 90vh;

Was there a reason for doing this? If you remove this line of code, it immediately looks a lot better. Generally in most cases, it's better to let the content create it's own height rather than setting a fixed one.

Hope this helps, and keep up the great work!

Marked as helpful

0

@obinneji

Posted

@12Kentos if the words in the advice are much it tends to display over the main container, especially in mobile view, that was why I extended the height to 90vh for mobile.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord