Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice generator app fetch async js

#solid-js#sass/scss
Zybartas 480

@ZybartasRingys

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


My solution to this challenge, I would appreciate your feedback how to improve my JS.

Community feedback

@zineb-Bou

Posted

Hi there, your solution looks good I am dropping some suggestions that may help you to improve your code even further.

1- Concerning the images, since they are for decoration don't keep them visible for the screen reader(we don't need it to read their source path).

2-The advice text instead of putting inside a <div> it's better to put inside a <p> tag.

3-Add an aria-label=" generate advice", to make the button readable by the screen reader.

Happy coding :)

Marked as helpful

0
Old 6,220

@Old1337

Posted

Hi there,

  • add text-align:center; to the advice div
  • put the quote inside a <blockquote> tag instead of div to be more semantic
  • Check the HTML report to fix accesibility issues

i hope this is helpful and goodluck

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord