Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Advice Generator App HTML/CSS

Laharl•1,000
@UrbanskiDev
A solution to the Advice generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello, Frontend Mentor coding community. This is my solution for the Advice Generator App.

It was a fun project to do as a first project to test the platform. I simply have a minor issue with the API, which does not refresh the advise presented when making a new request for some reason. Apart than that, everything went smoothly, and I'm eager to take on new challenges in order to become a better developer.

Feel free to leave a feedback on my work.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Eduardo•200
    @EDDuardOo-Code
    Posted almost 3 years ago

    Congratulations completing your challenge Urban

    if you want to show the advice when the pages load you can do that ,adding a event listener

    btnAdvice.addEventListener('click',() =>{
        getAdvice();
    }
    )
     window.onload = () =>{
        getAdvice();
    }
    

    also i like the desing and how you work with css variables, that makes changing colors a lot easier, if you want the card to be center you can use flexbox in the body, something like this

    body{
        background-color: var(--neutral-dark-blue);
      display:flex;
     justify-content:center;
    aling-items:center;
    min-height:100vh;
    }
    

    also it is better to work with classes cause we can reuse the code , id´s can get pretty heavy to work with , overall the project it is really good, hope to see more of your work and also see more of your projects , Keep going 😃👍

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub