Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 2 years ago

Advice Generator App

Whitney Dallas•80
@Wdallas12
A solution to the Advice generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This was a good quick project to refresh my knowledge of fetching API data. It took some light research to remember how to format the fetch function but outside of that this was a smooth process!

Any feedback is always welcome :)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Atif Iqbal•3,320
    @atif-dev
    Posted almost 2 years ago

    Hi, congrats🎉 on completing the challenge. Better take about following points:

    • You must be seeing Accessibility Issue, generated by FEM Report Generator. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
        <main>
            ---your code here----
        </main>
      <footer>
      </footer>
    </body>
    
    • Your preview page needs to be responsive for different screens. For a better preview, centered and responsive modify your code as follows:
    body {
        background-color: var(--dark-blue);
        display: grid;
        place-content: center;
        min-height: 100vh;
    }
    
    @media screen and (min-width: 500px)
    .container-card {
        /* margin: 25%; */
        /* max-width: 600px; */
        border-radius: 20px;
        box-shadow: 1px 7px 40px rgb(21, 30, 36);
    }
    
    .container-card {
        background-color: var(--dark-grayish-blue);
        margin: 0em 1em;
        max-width: 600px;
        position: relative;
        display: flex;
        flex-direction: column;
        justify-content: center;
        align-items: center;
        padding: 4rem 1rem 7rem 1rem;
        border-radius: 10px;
        box-shadow: 1px 3px 10px rgb(21, 30, 36);
    }
    
    • If you are enough comfortable with CSS better learn about responsive units and responsiveness. For responsivness learning, take Conquering Responsive Layouts short course.

    • When we open GitHub repository link, at right side you will find an About Section. There, also include a description and live preview link of your project.

    • In README file of your GitHub project's solution remove already present content and write about your own working flow, findings, new learned things, useful resources, etc.

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub