Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice generator app

Mustapha 540

@muben88

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, Frontend Mentor community! Hope you're doing great! This is my solution for the Advice generator app.

Happy to hear any feedback and advice.

Community feedback

Old 6,220

@Old1337

Posted

Hi there,

  • put the quote inside a <blockquote> tag instead of p tag to be more semantic
  • remove the padding top from the main tag and give the body these properties to center the element display:flex justifiy-content:center align items: center min-height:100vh
  • check the HTML report to fix accessibility issues

i hope this is helpful and goodluck

Marked as helpful

1

Mustapha 540

@muben88

Posted

@Old1337 It is very helpful! Thank you

1
niranjan 120

@niranjan-inofty

Posted

@muben88 Great work buddy! I have a suggestion, No need to pass the id for the API, just fetch from "https://api.adviceslip.com/advice/".

1

Mustapha 540

@muben88

Posted

@niranjan-inofty Thank you! Yes I know, I just wanted to try it this way.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord