Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

Advice generator app using golang in backend to create My own API

Kaouther•450
@Kaoutherbo
A solution to the Advice generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Abouelhouda Iliass•480
    @ilyesab
    Posted about 1 year ago

    Hi @Kaoutherbo, I reviewed your solution. really great work. I never realised that CSS Nesting was available in the browser without a CSS preprocessor. that was good to know. It also seemed you built the backend yourself using GO. as I have no experience in that I didn't take a look at that code.

    However I did take a look at the frontend code and below you can find some of my remarks:

    • I think it would be a better idea to use a button and not a div for the dice button to generate new advice. a button has the semantic role of ''button" and it is declared as such by screen readers. while your div won't be declared a button. you also cannot tab into it so if I don't have a mouse I'm gonna have a hard time. you can add a tabindex attribute to it to resolve that.

    • in relation to accessibility it might be a good idea to add an H1 even if it's visually hidden and add alt texts to your img elements.

    • in design terms I think you should increase a little the spacing between elements especially on mobile as they seem a little bit squished.

    Marked as helpful
  • Kaouther•450
    @Kaoutherbo
    Posted about 1 year ago

    Thank you for reviewing my solution and for your valuable feedback, I appreciate your suggestion and I'll make these improvements to enhance the overall user experience of the application.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub