Advice generator app using golang in backend to create My own API

Community feedback

• 

  P

  Abouelhouda Iliass•480

  @ilyesab

  Posted about 1 year ago

  Hi @Kaoutherbo, I reviewed your solution. really great work. I never realised that CSS Nesting was available in the browser without a CSS preprocessor. that was good to know. It also seemed you built the backend yourself using GO. as I have no experience in that I didn't take a look at that code.

  However I did take a look at the frontend code and below you can find some of my remarks:

  • I think it would be a better idea to use a button and not a div for the dice button to generate new advice. a button has the semantic role of ''button" and it is declared as such by screen readers. while your div won't be declared a button. you also cannot tab into it so if I don't have a mouse I'm gonna have a hard time. you can add a tabindex attribute to it to resolve that.

  • in relation to accessibility it might be a good idea to add an H1 even if it's visually hidden and add alt texts to your img elements.

  • in design terms I think you should increase a little the spacing between elements especially on mobile as they seem a little bit squished.

  10

  Marked as helpful
• 

  Kaouther•450

  @Kaoutherbo

  Posted about 1 year ago

  Thank you for reviewing my solution and for your valuable feedback, I appreciate your suggestion and I'll make these improvements to enhance the overall user experience of the application.

  11