Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

Advice generator app using Next.js

next, tailwind-css, vitest, shadcn
Tesla_Ambassador•3,070
@tesla-ambassador
A solution to the Advice generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I mainly did this project to enforce my newly-found knowledge on testing components. I used vitest and I'll probably give Jest a try in my next solution. It's pretty basic cause I was really concentrated on practicing with vitest so, no easter eggs 😭

What challenges did you encounter, and how did you overcome them?

Testing a component that had to get data from an API was challenging for me (Given that it was my first time using vitest). I tried following the tutorial I was learning from but it didn't help much cause the person obscured some important disclaimers in his videos. Also, he was using JavaScript while my solution is in TypeScript but I wasn't too proud to use AI, so a little bit of co-pilot and claude helped me figure out why my code wasn't running.

What specific areas of your project would you like help with?

Could you please look at my file structure and let me know if it's professional and yes... Please look at my testing code and... well generally my code. Let me know what I need to change. If you find problems with the UI and how I could improve it, I'm open to all your wisdom. I tried using a skeleton to prevent that blank space when the fetch API is still fetching data... Pun very much intended 😂

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    markus•2,700
    @markuslewin
    Posted 4 months ago

    Hey!

    I don't mind a good-looking skeleton, but if you wanted to, you could always fetch an advice on the server in Home, and send it to AdviceCard as initialQuoteData. That way, you'd avoid the null state and the useEffect!

    // page.tsx
    export default async function Home() {
      const quoteData = await fetch("https://api.adviceslip.com/advice").then(
        (res) => res.json()
      );
    
      return <AdviceCard initialQuoteData={quoteData} />;
    }
    
    // Card.tsx
    export default function AdviceCard({ initialQuoteData }: AdviceCardProps) {
      const [quoteData, setQuoteData] = useState<QuoteData>(initialQuoteData);
    
      const generateQuote = () => {
        /* ... */
      };
    
      return (
        <h1 className="text-sm sm:text-md text-primary-neonGreen">
          ADVICE #{quoteData.slip.id}
        </h1>
      );
    }
    
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub