Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Advice Generator App using typescript

typescript
nikoProg•120
@nikoProg
A solution to the Advice generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Any advice about the layout in general?

The button starts glowing upon hovering, but if you click it, the glow gets stuck, no matter where you move the mouse, until you click on something else. How can I make the button glow and stop glowing when I stop hovering? My solution is a bit of a hack, using ::after pseudoelement, so I am not sure how to fix it.

This was also my intro to typescript. I installed it, because I like that strongly-typed languages make it easier to fix some mistakes, so I hoped this could help. I didn't have much use of it yet, since the only script needed here is to fetch advice from the API.

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • David•7,960
    @DavidMorgade
    Posted almost 3 years ago

    Hello man, congrats on finishing the challenge, I think I know why your button is getting the box-shadow effect when clicked.

    You are using the :focus pseudoelement, this mean that your button will get the opacity prop every time is focused (when is clicked and you dont click in other elements), you dont need to set a focus or after to get the desired effect, you can remove both pseudoclasses and just keep :hover with these styles:

    #btn:hover {
      box-shadow: 0 0 2em 0.5em hsl(150, 100%, 66%);
      transition: box-shadow 500ms linear;
    }
    

    Hope this helps, just with the :hover pseudoelement you will get the desired result.

  • Tim•100
    @tlauffs
    Posted almost 3 years ago

    Try using the :hover Selector instead of an ::after pseudoelement to create the glow effect. It will only trigger on hover and you should only need a box-shadow to create the effect. You should also consider adding a :focus state for keyboard navigation as :hover states aren't shown.

  • Artur Harutyunyan•400
    @ArturHarutyunyan1
    Posted almost 3 years ago

    Make your .advice-container centered. *{margin: 0; padding: 0; box-sizing: border-box}. Remove body{padding: 10%;} and set body height to body{height: 100vh}

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub