Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice generator app with html, css and js

#fetch
sanket kumarβ€’ 300

@sanketcharanpahadi

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any suggestions or improvements are welcomed.

Community feedback

Moβ€’ 840

@MohamedAridah

Posted

Hello @sanketcharanpahadi, you solution is looking very good.πŸ‘πŸ‘

I have some feedback for you:

  • you can run getQuote() function when page loads for getting new advice every time.
window.addEventListener('load', getQuote);
  • you can use button instead of .expand div. It will be more Semantic.
<button class="expand flex">
      <img src="images/icon-dice.svg" alt="">
</button>

just add this property to the .expand

.expand {
    all: unset
}

I hope this wasn't too long for you, hoping also it was useful😍.

Goodbye and have a nice day.

Keep codingπŸš€

Marked as helpful

1
Oldβ€’ 6,240

@Old1337

Posted

Hello there! πŸ‘‹

Congratulations on finishing your challenge! πŸŽ‰

I have some feedback on this solution:

  • put the quote inside a <blockquote> tag instead of h1 to be more semantic

i hope this is helpful and goodluck!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord