@0xabdulkhalid
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- Your solution generates accessibility error reports due to
non-semanticmarkup
- So fix it by replacing the
<div class="advice-generator">with semantic element<main>to improve accessibility and organization of your page.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
@visualdenniss
Posted
@0xAbdulKhalid Hi,
Thanks, but please avoid copy-pasting same generic text over and over on every new submission.
Try to make your suggestion related to the posted submission and to the issues that are actually there.
I suggest you to please read and follow the community guidelines in order to not risk your account red flagged: See section called Copy/paste the same minimal feedback on multiple solutions in https://medium.com/frontend-mentor/frontend-mentor-community-guidelines-44303cc38aa6
Thanks.
@0xabdulkhalid
Posted
@visualdenniss
- Look at the code at line 8
- I'm not copy/pasting, I'm mentioning your code with proof
- Just head to your code and look at where you done the semantic mistake
Thanks.
@visualdenniss
Posted
@0xAbdulKhalid
Thanks for pointing it out semantic mistake.
I've just seen that tactic of repeating of automatical accessibility warnings in the comments too many times -which is the easiest and fastest way to earn points with minimal effort-, so that i've not even noticed that there is a minimal customization added.
