Skip to content
Submitted 6 months ago

Advice Generator

sass/scss
P
Øystein Håberg•13,260
@Islandstone89
A solution to the Advice generator app challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm satisfied using the fetch API! I also used npm to setup and build the project, as well as doing some configuration in package.json.

What challenges did you encounter, and how did you overcome them?

Positioning the button was somewhat challenging. I tried doing it with Subgrid, but in the end I ended up using absolute positioning.

What specific areas of your project would you like help with?

As always I'm open for any feedback :)

Code

Please log in to post a comment

Log in

Community feedback

  • Grace•32,130
    @grace-snow

    This looks good, just a few small improvements to suggest:

    1. Instead of trying to set two competing assertive aria-live regions, wrap the whole card in ONE aria-live set to "polite". Because you have two at the moment they overrule each other, meaning only one will be announced. There is no reason why these would need to be assertive either.
    2. The Dice button label needs to begin with the word "dice" so that it is easy to activate for voice control users. E.g. "Dice - Generate new random advice". This is especially important as you've told people to click the dice button in the help text.
    3. It looks like this challenge intends for you to use the picture element for the divider images as different onese are provided for mobile vs desktop.
    Marked as helpful
  • Dylan Heslop•2,460
    @dylan-dot-c

    This is a good solution, but thats why im here.

    I think(idk) that you are in jeopardy for getting 3rd place for mentor of the year and getting sidelined by the current 3rd place.

    I don't know if you care about the 3rd place and the free 1-year fem premium but I just wanted to let you know, and maybe try and help you if you actually care about it in some way.

    Just a random guy tho.

    Also checko out my solution and tell me what you think.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord