Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

advice generator using grid and axios.

axios
akhilchary08•40
@akhilchary08
A solution to the Advice generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I used css grid for structuring the html. For fetching data from the api endpoint axios has been used. There are 224 advice slips in advice slip api. For every click from the user a function is called. In the function call a random number is generated using Math.random() function of javascript which ranges between 1 to 224. for every random generated number serves as an Id and using the Id corresponding advice is fetched. I hope learn further from others solutions. 🙂

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Sandro•1,150
    @sandro21-glitch
    Posted over 2 years ago

    Hi akhilchary

    Here are a few suggestions for improvement on your code:

    Use semantic HTML elements where appropriate, such as <header>, <nav>, <main>, <article>, <aside>, and <footer>.

    Provide alternative text for the <img> elements using the alt attribute, to make the content accessible for people using screen readers.

    Use CSS variables to store values that are used repeatedly throughout your styles, such as colors or font-sizes. This will make it easier to make global changes to your styles.

    Try to avoid using inline styles and instead use CSS classes for styling.

    Use descriptive and meaningful class names, such as .advice-card instead of .main to make your code more readable and understandable.

    Use CSS Flexbox or Grid for layout instead of position absolute where possible, as they are more versatile and easier to use for most layout tasks.

    Happy Coding

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub