Advice Generator w/ Responsive Design - HTML, CSS, Vanilla JS

Community feedback

• 

  Fazza Razaq Amiarso•2,320

  @fazzaamiarso

  Posted about 3 years ago

  Hello Justin!

  Your use of API is good but redundant. You don't need to do async/await because you already resolve your promise with then. Also, it's better to stick with 1 method, either chaining with then or async/await So, here is the implementation:

   function getAdvice() {
      fetch(adviceAPI)
          .then(response => response.json())
          .then(data => {
              quoteEl.textContent = `"${data.slip.advice}"`;
              adviceNumEl.textContent = data.slip.id;
          })
          .catch(console.error);
  }
  

  I hope it helps! Cheers!

  11

  Marked as helpful
• Account deletedPosted about 3 years ago

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • put the quote inside a <blockquote> tag instead of div to be more semantic

  • check the HTML report to fix accessiblity issues

  i hope this is helpful and goodluck!

  11

  Marked as helpful