Skip to content
Submitted about 3 years ago

Advice slip generator with react.js ,axios, advice slip API

bootstrap, node, react, sass/scss, typescript
frontendgeek•295
@yusufweb
A solution to the Advice generator app challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

This is my second project using reactjs, though simple but i learned alot while doing it. Your feedback is highly welcome.

Code

Please log in to post a comment

Log in

Community feedback

  • CyrusKabir•1,885
    @CyrusKabir

    hello my dear friend ♥ besides of good points @MikeBish13 said I just want mention that your component it's not interactive with keyboard (tab key). I mean it is but we can't understand because there is no outline (because your component button have 0 outline) or something that tells the button is focused so it's equal to non interactive with keyboard

  • Michael Bishop•1,080
    @MikeBish13

    Great job! The app functions pretty smoothly so well done.

    A couple of things I noticed in terms of the design:

    1). Some of the sizings seem to be a little off, specifically the size of the central box and the text of the quotes compared to the design. See if you can line these up more accurately.

    2). The green button doesn't appear to be centred in the middle of the advice box. There is a million and one ways of doing this, so have a play around and see if you can come up with something.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord