advice-generator-app

Community feedback

• 

  Shonuff•280

  @TheShonuff

  Posted about 3 years ago

  I looked at your project and noticed you're not loading in a new quote on the button click event. I Struggled with this for a bit myself and found this to be helpful. Here is the code I implemented

  let response = await fetch("https://api.adviceslip.com/advice", { cache: "no-store", });

  It would also appear you might want to adjust some of your design parameters. You have your sizing a bit off. Like your .item class is way too big and your font for para is too small.

  00
• Account deletedPosted about 3 years ago

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • put the quote inside a <blockquote> tag instead of p to be more semantic

  • check the HTML report to fix accessiblity issues

  • add cursor pointer to button so that the user knows its clickable

  i hope this is helpful and goodluck!

  00