@alex-kim-dev
Posted
Hi Connor, I've been inspecting some of your solutions and I think you're doing a great job! I like the visual accuracy and how the code is organized. There's one thing that I spotted - some BEM elements which are nested inside other elements have this type of naming: block__elem1__elem2__elem3
. However it's not recommended in the BEM documentation (Guidelines for using elements - nesting). So instead of a markup like this:
// pug
nav.desk-nav
ul.desk-nav__menu
li.desk-nav__menu__item
.desk-nav__menu__item__underline
it's recommended to do it this way:
// pug
nav.desk-nav
ul.desk-nav__menu
li.desk-nav__item
.desk-nav__underline
Also I've noticed you have a lot of solutions using Svelte, so when I'll be trying it out I'll definitely come back to them and learn. Have a good one!
@zuolizhu
Posted
Big thanks Alex! @Alex-K1m I was struggled on naming those elements and tried to shorten their names, I will try your strategies on my next project 😎!
Yeah I'm a big fan of Svelte. For multi pages project, I used Sapper, which is the same thing you learned from Svelte plus its file-based routing system. Highly recommended😆!