Easybank landing page | pure HTML SCSS and JS

Solution retrospective
Feedbacks are super welcome!
Almost pixel perfect 😆.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @alex-kim-dev
Hi Connor, I've been inspecting some of your solutions and I think you're doing a great job! I like the visual accuracy and how the code is organized. There's one thing that I spotted - some BEM elements which are nested inside other elements have this type of naming:
block__elem1__elem2__elem3
. However it's not recommended in the BEM documentation (Guidelines for using elements - nesting). So instead of a markup like this:// pug nav.desk-nav ul.desk-nav__menu li.desk-nav__menu__item .desk-nav__menu__item__underline
it's recommended to do it this way:
// pug nav.desk-nav ul.desk-nav__menu li.desk-nav__item .desk-nav__underline
Also I've noticed you have a lot of solutions using Svelte, so when I'll be trying it out I'll definitely come back to them and learn. Have a good one!
- @ovidiuantonio
Hello,
Very nice solution! You did a great job! Two thing that I found, and need some improvement, are:
- add hover state for the article title
- try to find a better breakpoint for the nav switch. The nav stats getting off the screen. Try to replace 640 with 740 or even 800.
Happy coding! Keep going!
- @magdakok
How cool is that! :D
- @ramsaysewell
Hey Connor,
This looks really good! Congratulations on getting it so close to the design, I would say its almost pixel perfect too!
I like how semantic your code is and the use of BEM is very well respected.
Great job! Keep it up!
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord