Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 5 years ago

Easybank landing page | pure HTML SCSS and JS

Connor Z•5,115
@zuolizhu
A solution to the Digital bank landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Feedbacks are super welcome!

Almost pixel perfect 😆.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Alex Kim•1,325
    @alex-kim-dev
    Posted almost 5 years ago

    Hi Connor, I've been inspecting some of your solutions and I think you're doing a great job! I like the visual accuracy and how the code is organized. There's one thing that I spotted - some BEM elements which are nested inside other elements have this type of naming: block__elem1__elem2__elem3. However it's not recommended in the BEM documentation (Guidelines for using elements - nesting). So instead of a markup like this:

    // pug
    nav.desk-nav
      ul.desk-nav__menu
        li.desk-nav__menu__item
          .desk-nav__menu__item__underline
    

    it's recommended to do it this way:

    // pug
    nav.desk-nav
      ul.desk-nav__menu
        li.desk-nav__item
          .desk-nav__underline
    

    Also I've noticed you have a lot of solutions using Svelte, so when I'll be trying it out I'll definitely come back to them and learn. Have a good one!

  • Ovidiu-Antonio•3,125
    @ovidiuantonio
    Posted about 5 years ago

    Hello,

    Very nice solution! You did a great job! Two thing that I found, and need some improvement, are:

    • add hover state for the article title
    • try to find a better breakpoint for the nav switch. The nav stats getting off the screen. Try to replace 640 with 740 or even 800.

    Happy coding! Keep going!

  • Magda Kokot•1,425
    @magdakok
    Posted about 5 years ago

    How cool is that! :D

  • Ramsay Sewell•585
    @ramsaysewell
    Posted about 5 years ago

    Hey Connor,

    This looks really good! Congratulations on getting it so close to the design, I would say its almost pixel perfect too!

    I like how semantic your code is and the use of BEM is very well respected.

    Great job! Keep it up!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub