Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Almost similar looking solution using Internal CSS

Vivek Kumar Rahul•10
@vivekrahul
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


How to apply border-radius to an image? i tried making a div for the same but it didn't work for 5 % value? Can you all suggest something for the same ?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • StanishCode•120
    @StanishCode
    Posted over 2 years ago

    Using the overflow property on a parent container for an image is an easy way for the parent div and the image to have the same border radius. An important note, the image must be as big as the parent container.

    .image-div { display: inline-block; border-radius: 20px; overflow: hidden; } .image { text-align: center; padding: 15px; width: 100%; height: 100% }

    Marked as helpful
  • Ecem Gokdogan•9,380
    @ecemgo
    Posted over 2 years ago

    Some recommendations regarding your code that could be of interest to you.

    • If you want to make the card centered correctly, you'd better add flexbox and min-height: 100vh to the body
    body {
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
    }
    
    • If you use flexbox in the body, you don't need to use margin in the .main-div to center the card
    • If you use max-width instead of width, it makes the card responsive and you can reduce the width a bit if you want
    • If you want to give the gap between the content and the border of the card, you can use padding
    • I've given border-radius: 5%; to .main-div and it works. You can update it if you want
    .main-div {
       /* margin: 10% auto 10% auto; */
       /* border-radius: 15px; */
       border-radius: 5%;
       background-color: white;
       /* width: 330px; */
       max-width: 280px;
       padding: 15px;
    }
    
    • In addition to that above, in order to make the card responsive and the image positioned completely on the card, you'd better add width: 100% for the img in this way:
    • Again, I've given border-radius: 5%; to .image and it works
    .image {
        /* text-align: center; */
        /* padding: 15px; */
        /* width: 300px; */
        width: 100%;
        /* border-radius: 10%; */
         border-radius: 5%;
    }
    
    • You don't need .image-div and you can remove it
    /* 
    .image-div {
       display: inline-block;
       border-radius: 20px;
    } 
    */
    
    • If you reduce padding of p, it would look better
    p {
      /* padding: 40px; */
       padding: 10px; 
    }
    

    Hope I am helpful. :)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub