Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

API- Generator, Advice Generator with some jokes as extras

@VaibhavBhardwaj23

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

Elaine 11,420

@elaineleung

Posted

Hi Vaibhav, good job on the whole! I think you did well in trying to bring in another API when this one wasn't working for you.

I just checked my advice app solution to see whether the API is having issues, and it looks like everything is working fine for me. If you happen to be using Firefox (which is what I use), you may run into a problem where the next advice either does not load at all or does not load it right away. To fix this, you can try adding an object in the fetch like this:

fetch("https://api.adviceslip.com/advice", { cache: 'no-cache' })

As for your app right now, the one suggestion I have is to reduce the letter spacing, as right now the 4px letter spacing makes it quite hard to read the text.

I hope you can try the advice API again and see if it works for you!

1

@VaibhavBhardwaj23

Posted

@elaineleung Thank you! Yes I am using firefox. I'll try to implement the suggestion and update the solution. Thank you for your feedback 😇 //Update @elaineleung it worked thank you so much !

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord