Our reporter did not find any issues in this project! π
Design comparison
Reports
Mustafaβs questions for the community
hey Everyone,
This is my second project on front-end mentor and i would love to have your opinion about my project or if there is any comment to improve
Community feedback
Hey Mustafa, nice work on this challenge. It's responsive and the form validation for the email input works when the user submits the form with no input. One improvement you could make would be to expand your email validation to include instances when the user inputs strings that are not valid email addresses. I did this by using a regular expression https://stackoverflow.com/questions/46155/how-to-validate-an-email-address-in-javascript
Another suggestion is to add some more whitespace on mobile screen widths. It could use more of a margin between the image and the heading as well as some more padding on the left and right sides of the hero-content. Happy coding!
2
@Mostafa-T
Posted
@En-Jen Hey, thanks for your feedback i really appreciate it that you gave sometime to review my project. Actually, i have done this validation to another project here and will do that improvement on this project. Keep up your great work, Mustafa t.
0
@cesar-guerrero84
Posted
i like that design :D
0
@Mostafa-T
Posted
@cesar-guerrero8i4 Thank you!! Appreciate it π
0
Please log in to post a comment
Log in with GitHubJoin our Slack community
Join over 180,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!