@vanzasetia
Posted
Greetings, Stephen Lyssy! π
Good effort on this challenge! π
I have a few suggestions for this solution.
- I notice that you used
button
to navigate the user to another page. Why don't use an anchor tag? - For the
hero-title
, I recommend simplifying it. You can usemix-blend-mode
to make the text adapt to the background color. CSS Tricks has a great article that will explain how to do it. - For the social media links, I recommend wrapping each of the social media icon with an anchor tag. It's a social media link, so it needs to be wrapped by a link element.
- I suggest making the
img
as a block element and setmax-width: 100%
to make it easier to work withimg
element. - Never use
100vw
on anything as it doesn't account for scrollbars when present. It may only ever introduce potential overflow/scroll bugs. - Use single class selectors for styling whenever possible instead of
id
.id
has high specificity which can lead to a lot of issues on the larger project. It's best to keep the CSS specificity as low and flat as possible. π - The logo images are important content of the site. It should have some alternative text to them. Otherwise, the screenreader users would not know the name of the site.
That's it! I hope you find this useful! π
Marked as helpful
@Slyssy
Posted
@vanzasetia Thank you for the feedback. I usually do set buttons as anchor tags, but I just saw this onclick solution, and I wanted to try it. I mean, it works, and it's a simple solution for a button. I just forgot to do it on the social media links.
Thank you for letting me know about the mix-blend-mode. I've never heard of that before. I'm still very new to coding. That would have saved me a lot of headaches. I will update my code to reflect that. Very cool! Thank you.
@vanzasetia
Posted
@Slyssy You're welcome! π
Regarding the button
, it behaves like a link but it is a button
element. It may not confuse normal users. But, screenreaders would pronounce it as a button
so the screenreader users will think that it is a button
(perform an action) for sure. So, I recommend using anchor tag instead.
Marked as helpful
@Slyssy
Posted
@vanzasetia I did not know that. I will make the update when I get a chance. Thank you for the feedback.