Article component built with Sass, Flexbox, & vanilla JavaScript

Community feedback

• 

  

  Emmilie Estabillo•5,580

  @emestabillo

  Posted over 4 years ago

  Hi Jen, great job! Component is responsive and popup works well. Just really minor tweaks here:

  • I'm not getting misalignment on the card-info on my end, but the SHARE text could be vertically centered
  • .card has a bottom margin. Not sure why but since the article is centered via flexbox, you might not need it. Maybe to match the design? Playing with paddingand the contents inside the divs seem to work better for me.
  • I think the max-width for smaller devices can be reduced so it's not laying wide before the breakpoint. Of course this is just a matter of preference :-)
  • the box-shadow is slightly heavier than the design

  If you haven't already, download the chrome extension PerfectPixel and use it together with the sketch files to get really close to the design. Hope this helps :-)

  21
• 

  Sebastian Urbaniec•170

  @surbaniec

  Posted over 4 years ago

  Hello, on desktop view avatar, card__info and share btn are off the card. Also your social links are not centered within div

  12