Submitted about 3 years ago

Article preview challenge with a lil bit of JS

Vjekoslav• 485

@Vj3ko

Preview site View code

This is a solution for...

Article preview component

HTML
CSS
JS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

finished article preview challenge, if someone can take a look at it and give some feedback, it would be awesome :)

Community feedback

ApplePieGiraffe• 30,545

@ApplePieGiraffe

Posted about 3 years ago

Hi there, Vjekoslav! 👋

Good work on this challenge! 👍 The card component looks great and I like the smooth transition of the social media popup in the mobile navigation! 🙌

I think this StackOverflow question might help you get rid of those errors in your solution report and make your solution more accessible. 😉

Keep coding (and happy coding, too)! 😁

Vjekoslav• 485

@Vj3ko

Posted about 3 years ago

@ApplePieGiraffe oh thanks for that, fixed it. i read the error and said to myself i will fix it later, and then forgot about it : /

JK• 345

@JakubKepak

Posted about 3 years ago

Man, that is one awesome solution! One thing I would maybe do differently is to set outline to none when .person_article-share is focused and I would add .person_article-share:focus same as you have .person_article-share:hover.

But that's maybe just my view on outlines.

Really nice job!

Vjekoslav• 485

@Vj3ko

Posted about 3 years ago

@JakubKepak thanks man, for your time reviewing my code and giving feedback, i really do appreciate it, and u are right about outline, thanks for that insight

Vjekoslav• 485

@Vj3ko

Posted about 3 years ago

@JakubKepak also, i added focus state, it really does make a visible change, thanks again, forgot about that outline stuff :D

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord