@pikapikamart
Posted
Hey, great work on this one. First, it is great that you managed to pull this off, awesome. The layout in desktop looks great, responsive and the mobile layout looks great as well.
Some suggestions would be:
- Avoid using
height: 100vh
on a large container especially thebody
tag, this makes the element's height limited to the remaining viewport/screen's height. Instead usemin-height: 100vh
, this takes full height and allows the element to expand if it needs to. Also you don't need thewidth: 100%
as well. - If you inspect the
.container
selector, you will see that it has no dimension, it is because thefigure
inside it is usingposition: absolute
which makes the element out of the flow. You don't need that in the element. You can remove theposition: absolute
and also, you don't need this on thefigure
:
position: absolute;
position: relative;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
- I think the highlighted text is not really heading tag, since most likely on a testimonial, the person's name should be the heading tag because testimonial doesn't really have a topic title. Instead, I would make use of the
h1
in here as a screen-reader only text, meaning it will use ansr-only
class, you can search that one up and how it is used. alt
value for the person's image should only be the name of the personalt="Michelle Appleton"
. Avoid adding words that relates to "graphic" such as "avatar, image, logo.." since it is already an image, no need to describe it as one.- Name of the person should be a heading tag.
- The toggle works but it is not accessible for all. When creating interactive components, use interactive elements. On this one, you should use
button
and notspan
. Thebutton
will havearia-expanded="false"
as a default attribute. This will be change totrue
if thebutton
is toggled. Since there is no text content inside thebutton
that a screen-reader can read, you would use anaria-label
attribute or ansr-only
element inside thebutton
. The value for whatever method you will use should describe what does thebutton
does. A value could be "social media platform to share info". - The
svg
inside the toggle needs to be hidden since it is just a decoration, so you should addaria-hidden="true"
as an attribute on thesvg
. - The placement of the toggle and the dropdown is incorrect. The dropdown should be placed after the toggle on your markup, swap them up.
- Since the social media links are "list" of links, you could use an
ul
element on them. - The
aria-label
for eacha
tag should be the name of the social media, likealt="facebook"
this way, users will know where this link would take them. - The
svg
inside thea
tag should be hidden, usearia-hidden="true"
on it.
Aside from those, great work again on this one.
Marked as helpful