Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Article Preview Component

Abhijit Paul• 195

@ethabhijit

Desktop design screenshot for the Article preview component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Can anyone give me suggest me how to add arrow on the share container.

Community feedback

Raymart Pamplona• 16,140

@pikapikamart

Posted

Hey, great work on this one but there seems to be a lot of issues when resizing the browser.

  1. The components jumps around the screen. Opening up the dev tools, the component starts going in different direction, especially the share container and the container of the person. So to remedy this, you can just omit/remove the height: 40%; that is declared in your #component-container selector. I can see that you made use of different scaling units. Like vh, which I think is not the best choice in here, if you were setting it a component which does not hold a large group of elements, like the body tag. Removing that height: 40% will greatly improve the UI.

  2. It will be better that your share-container selector, is inside the #component-container. This way, you have secured it, that it will be only relative to the parent container. But you need to specify position: relative in the #component-container. So nesting that in your html will really help you to position it easily. Because right now, it is relative to the body, which is not ideal for the pop up to be contained.

My best advice is to declare a fixed unit, a fixed height on the container and fixed width. Then using only min-height: 100vh on the body tag. This will make sure that your body's minimum height, is 100% of the viewports or the screen's height.

A lot to be refactored, but those are really important. But if you need help, just drop your query okay^

0

Abhijit Paul• 195

@ethabhijit

Posted

@pikamart Thanks for your valuable suggestion.

0
kirubakk• 245

@KIRUBASHANKAR26

Posted

This is my suggestion to use ::before selector to make arrow (it's means #share-container::before)

0

Abhijit Paul• 195

@ethabhijit

Posted

@KIRUBASHANKAR26 Thanks for your valuable suggestion.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord