Article Preview Component

Community feedback

• 

  Vanza Setia•27,715

  @vanzasetia

  Posted about 3 years ago

  Hello there! 👋

  For the share button, it should use button element instead of just i element. Also, it's recommended to use span instead of i element and add visually hidden text to make it accessible by screen reader users.

  The pop-up contains social media links so wrap each social media icon with an anchor tag and add aria-label to the anchor tag to make it accessible for the screen reader users.

  I would recommend adding max-width to the card or container element to prevent it from becoming too large on the mobile layout.

  I hope this helps!

  P.S. I recommend reading this article from Sara Soueidan about creating "Accessible Icon Buttons".

  00

  Marked as helpful
• 

  Abdul•8,560

  @Samadeen

  Posted about 3 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use nest all of your divs in a main tag to improve accessibility
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  01

  Marked as helpful