Article preview component | Flexbox + Grid

Community feedback

• 

  Elaine•11,360

  @elaineleung

  Posted almost 3 years ago

  Well done Eduardo! I like what you did here, and everything seems to work well. Looking at your report, you do have some HTML issues to fix, namely the transition property having too few values, since transition is used as a shorthand for a few transition properties (e.g., transition-duration, transition-delay, etc.). You need at least the transition-propertyandtransition-duration(as in not justtransition: 0.2sbuttransition: all 0.s`), or else the report will say you have errors.

  One suggestion I have is to use hyphenated names instead of camel case; it's not like you would get errors if you use camel case, but hyphenated names is the convention that's normally used (while camel case is typically used in JS). Also, it's easier to separate the parts into blocks and elements hyphens and underscores, like what the BEM system uses.

  Once again, great work :)

  00