Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

SCSS Article preview component with JS share menu

sass/scss
maia•300
@maiaflow
A solution to the Article preview component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Open to any ways I could improve!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Eric Salvi•1,350
    @ericsalvi
    Posted over 2 years ago

    Hey @maiaflow,

    Great job on another challenge. You are unstoppable!

    I am not seeing too much from a design POV except I feel the card can get too long on very wide screen sizes. So I would probably try setting a max-width for body main on the desktop only. That way when the screen gets really wide, the card doesn't get really wide as well.

    Also, one thing that I like to do is with the footer section in the card you have a margin-top being set to push it down the page a bit. Sometimes what I like to do is set the actual section content to display: flex and flex-direction: column. Then you could change the margin-top to auto. What this will do is push the footer to the bottom of that section and so no matter what height the card ever becomes, the footer will always stick to the bottom of the container.

    You have 3 invalid issues in your HTML. The social sharing icons you have do not have the alt attribute. Even if an image doesn't need to have a need for actual alt text, the attribute still needs to be present. Just add alt="" to your 3 images to fix those issues.

    The JS looks great and you should be proud of yourself for getting it done. The more of these that you do, the easier it will become. Also, the new word you created called sharrow is pretty cool!

    Let's chat more about vendor prefixes.

    Keep up the momentum!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub