Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

Article Preview Component - React Based

accessibility, react, styled-components, semantic-ui
Brian Johnson•210
@BrianJ-27
A solution to the Article preview component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This project was fun and challenging.

What I found most difficult about building this project is knowing the best approach in knowing when and how to set aria attributes like aria-expanded on click in React.

Here are areas I am still unsure of: (I am guessing these questions could fall under best practice questions too)

  • If I successfully implemented the aria-expanded attribute to the button element onClick with React.js
  • For adding modals, does it matter where you add them in your layout. I was given advice to move the shared content modal to inside the card footer div in lieu of having it within my main tag. I followed the advice but I didn't understand exactly why I moved it because it didn't seem to change anything
  • I added aria-hidden= "true" on all inline SVG's as instructed too but again I didn't know why I did it. What is the reason? Also does this apply to images too? If not, then why?
  • Also for the modal, was it the right decision to use position absolute on it? I thought about using transform: transformY(px) on it but thought positioning was better
  • Were there any areas of my code, that aren't very readable to the next developer? Ex) using styled components allows you to create your own named components. Do my names make sense or can I simplify it?

This is all I could think up for now. Thank you for your time

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Fazza Razaq Amiarso•2,320
    @fazzaamiarso
    Posted about 3 years ago

    Hello Brian! Nice try on implementing those accessibility improvements!

    I can answer some of your questions.

    • The first thing you want to make sure accessible is the keyboard access. When I go through your page with keyboard, I was lost. You MUST have either focus or focus-visible style to focusable elements. https://www.w3.org/WAI/GL/UNDERSTANDING-WCAG20/navigation-mechanisms-focus-visible.html
    • aria-hidden="true" is to prevent screen readers from reading or detecting the SVGs.

    I know it's tough to learn accessibility as there are not many resources out there. But, I can give you a useful tips to learn accessibility that I discovered along the way. Please try to go read and understand the source code of libraries such as Reach UI and Headless UI. They are amazing libraries on making accessible components that you can learn from.

    I hope it helps! Cheers!😁

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub