Skip to content
Submitted over 3 years ago

Article preview component using flexbox and grid

Duyen Nguyen•950
@Duyen-codes
A solution to the Article preview component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I was having hard time positioning the pop-up share panel. I was literally trying to guess the value of rems for the top and right values. Please have a look at the codes and give me some feedback on my approach and codes. Any help greatly appreciated!

Code

Please log in to post a comment

Log in

Community feedback

  • David Osorio•560
    @osoriodev

    Hello there.

    You have some issues in the HTML

    • For accessibility, all buttons must have text. In case there is only one icon or image, the aria-label attribute must be used (for example: <button aria-label="Share"></button>)
    • The headings should increase by one (You are using a h3 after the h1)
    • It is recommended to put the script before closing the body tag, this is to ensure that the DOM is ready when the script is executed.

    Anyway, your result was great. I hope I have helped.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord