Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

ARTICLE PREVIEW COMPONENT using Flexbox and Vanilla JavaScript

Ken 935

@kenreibman

Desktop design screenshot for the Article preview component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Wow, this took so long to make. After countless hours of studying JavaScript, watching crash courses and tutorials. I was finally able to create a simple pop-up on a page.

I'm very confident in HTML and CSS now, especially Flexbox. I hope I can have challenges that push me to utilize more CSS Grid. I also appreciate the challenge and countless hours of studying I went through to learn a little JavaScript.

I am still in the learning process of vanilla JavaScript, and I know the code I wrote for the pop-up is not exactly the cleanest. If anyone has feedback on how I can make the code cleaner, or acceptable for the industry, I would greatly appreciate any sort of feedback that you give me out of your time.

Community feedback

P
Ken 4,915

@kens-visuals

Posted

Hey @lmaoken 👋🏻

I took a look at your JS as you asked, and here are some suggestions:

  • First, it would be really great if you declared variables for all the selections, so you don't have to write document.querySelector('') each time. For example:
const btn = document.querySelector('.btn__share');

of course you should use more descriptive names, this was just a demonstration.

  • Next, I suggest creating classes in CSS and give all the styling that should be applied to the button or whatever you're toggling and then in JS just add and remove those classes or even better use toggle method. You can check out my **solution to see how to do it. When, you give styles with .style it adds inline styling, and then it's pretty much stuck in your HTML, unless you refresh the page, so it would be a lot better to implement those styles in CSS then play with the classes in JS.
  • Lastly, you should add `aria-expanded="false" in HTML, and then according to the state of the pop-up change to true, I also have that implemented in my solution.

I hope this was helpful 👨🏻‍💻 other than that, you did a superb job, I knew you got this and this is just the begging. You've got a lot to do and to practice, but you'll get there, trust me. Cheers 👾

Marked as helpful

1

Ken 935

@kenreibman

Posted

@kens-visuals Thank you! You explained this so well. I really appreciate you taking time out of your day to drop some valuable knowledge.

Great work on your recent projects!

0
P
Ken 4,915

@kens-visuals

Posted

@lmaoken you're welcome, as always glad to be helpful 😇

Thank you, I really appreciate it 👌🏻

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord