Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

article preview using css grid and javascript to toggle img box

accessibility
Eric Aguayo•1,055
@EAguayodev
A solution to the Article preview component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?
What challenges did you encounter, and how did you overcome them?
What specific areas of your project would you like help with?
Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Rupali•890
    @rupali317
    Posted 12 months ago

    Hello Eric

    I am following the learning path for Javascript. While following this learning path, the front-end mentor team has requested me to provide feedback on your solution. I am delighted to share the following suggestions for your approach on article preview component:

    A) HTML Semantics

    • You should use h1 instead of h3. Especially for assistive technology, they rely on these headings to understand the page structure. h1 will tell the assistive technology that there is a main heading and it will help it understand how the page is structured.

    • Instead of <div class="left"></div> how about you use the <img> tag? It makes the HTML more semantical. Semantical structure is better for assistive technology.

    • For the share icon, you can consider having a <button> tag wrapping it because the share is supposed to be an interactive element that toggles the tooltip.

    B) CSS improvements

    • The .share__box has a fixed width and that is why the tooltip is not showing properly in the mobile view. You might want to adjust the dimensions accordingly to the mobile view.

    C) General comments

    • Use rem instead of px as the former is ideal for scalability.

    • You are having the script towards the end of the body. Another approach in terms of better performance, is to have the script within the head tag and add defer attribute: ``. This means that the script and the HTML will be loaded in parallel and only when the entire DOM is loaded, the script will then be executed. In your approach, the script downloads and executes only after the loading of the DOM, so it is slower.

    Hope the above helps. Let me know if the suggestions work

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub