@RayaneBengaoui
Posted
Hello Marco,
Congrats for completing the challenge ! 🙂
I'd like to suggest :
-
Increase the spreading of your box-shadow, here it looks too 'sharp' compare to the design. So on your
--bs
variable, increase the third value which correspond to the blur-radius. You can even add a 4th parameter to affect the spread-radius. -
Add
cursor: pointer
to your share button. -
On your media query (min-width: 1200px) you have an
overflow: visible
, thus, on a larger screen your top/bottom left edges are not rounded. So you could probably remove this line from your media query. -
Add more spacing on the mobile view as the text seems a bit squashed.
-
Lastly, you are repeating a lot of code such as
display: flex; justify-content:...
so using SASS @mixins could simplify your workflow and make your code smaller.
Overall, well done for the challenge and happy coding ! 😃