Ana Luz Cervantes• 1,705
@analuzcervantes
Posted
Welcome to the frontendmentor community! 🎉
Your design is very good, but if you allow me I would recommend the following:
- Notice that your background is in a div tag with the card-layer class, to avoid the white borders, move everything related to the background to the body. So it would cover the whole page.
- In the card-layer, note that your height has a value of 700px, it would be a better practice to use values 100vh for heights and 100vw for widths, [I leave you more information here](https://css-tricks.com/fun- viewport-units/)
I will leave you some articles that will serve you for this and future challenges:
Be well, keep coding! 💻👾
5
Go Ushiyama• 135
@Enoah35
Posted
@analuzcervantes Hello! Sorry for the delay. I appreciate a lot your feedback. I have been going back to re-visit the HTML and CSS after I have tired my second challenge. There, I learned about vh, Flexbox, Grid and I am planning to re-try this challenge. I will try applying your advice and the new knowledge I got from re-visiting these topics.
Thanks again!
1
