Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Base apparel coming soon

Moh 230

@Moh2106

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


hi everyone this is my project in javascript if there is anything to improve my code any comments would be welcome Thanks.

Community feedback

T
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hey there, Moh! 👋

Nice effort on this challenge! 👏

I'd like to suggest,

  • Taking a look at your solution report and trying to clear up some of the errors that are there in order to improve the accessibility of your solution (it looks like you need to label the input elements on the page).
  • Removing the default border around the submit button and using the linear-gradient function to color its background (to match the original design a little more closely).
  • Adding overflow-x: hidden to the page to prevent a horizontal scroll bar from appearing when the width of the screen decreases in the desktop layout.
  • Adding a little space around the top/bottom of the logo in the header in the mobile layout. 😉

I hope those few tips help. 🙂

Keep coding (and happy coding, too)! 😁

Marked as helpful

0

Moh 230

@Moh2106

Posted

@ApplePieGiraffe thanks for your remark

1
Amon 2,560

@A-amon

Posted

Hello! It's a nice work~ But it would be better if you can put the input field and button into a form tag. This will allow me to press Enter to submit the email with the "submit" event instead of just "click". And remove the 90% width so that there's no white-space at left and right of page.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord