@emestabillo
Posted
Hey @catherineisonline, good job at staying true to the design. Just have a few thoughts:
- I would try increasing the breakpoint to 900px + or so. Still looks a little tight at 801px and the text is almost touching the gutter.
- On wider widths, the logo starts disappearing. Use an
img
tag or nest the svg in the header. The logo is such an important part of a page and shouldn't be used as a decorative background image. - The error and success messages flashes a little too quickly and should probably stay until the user edits or submits again.
- The form submit is an interactive element, meaning it implies an action from the user, and therefore should be a
button
instead of a div. Great job on the hover, I'd add atransition
to make it smoother. - Minor: looks like input should have a transparent background and label be desaturated red with some opacity.
- I highly recommend going mobile-first. It's easier to make elements larger than to have them scale down to fit smaller screens. It also often results to less code.
Hope this helps :-)
Marked as helpful
@catherineisonline
Posted
@emestabillo I will take a look at these and try them out, thank you for the feedback!