Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

Base Apparel Coming Soon Page | HTML5, CSS Flexbox, JS

Syazwan Fitri•400
@syzwnftr
A solution to the Base Apparel coming soon page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Any feedback for improvement are greatly appreciated.

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Raymart Pamplona•16,040
    @pikapikamart
    Posted almost 4 years ago

    Hey, awesome work on this one. Layout in desktop looks great, it is responsive and the mobile layout is great as well. One thing though, inspect the layout in dev tools at the bottom, the img starts to shrink.

    Some suggestions would be:

    • The alt value for the website-logo should only be alt="base apparel" lose the word "logo", since img is already an image, no need to describe it as one.
    • The input as well as the button should be inside a form element, since this will, on real site, will send data.
    • The input should have aria-invalid="true" being set to it, if the user submitted a wrong input:
    if ( input is wrong){
      input.setAttribute("aria-invalid", "true");
    } else {
      input.removeAttribute("aria-invalid");
    }
    

    This way, users will know that there is an error. Also have a search for aria-describedBy you will use this to link up the id of the error-message to the input element.

    • The button should have type="submit" and have aria-label="submit form", this way user will know what this button will do.
    • Lastly, the img that you are using, do not use max-height: 100vh, this creates the bug that inspecting layout in bottom dev tools, the img shrinks. You don't have to add that really.

    Aside from those, really great job on this one.

    Marked as helpful
  • Ericka Mae Mateo•140
    @erickamae-mateo
    Posted almost 4 years ago

    It's great! You just need to add spacing between your text. Whitespace helps your design to be more readable and words won't look crowded.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub