Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Base Apparel coming soon page

Alex 100

@Alex6pc

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello guys.

I will be glad, if you can give me advice how to improve my code.

Alex

Community feedback

Prince Roy 1,210

@iprinceroyy

Posted

Great work @Alex6pc, I would suggest some points here :

  1. Use kabeb-case for the class name.
  2. Wrap the contents inside the main tag
<body>
<main>Your contents..</main>
</body
  1. Always use the relative unit rem.
  2. You can use CSS latest functions min(), max(), and clamp() for responsive fonts, margin, padding, and width.
  3. There should be the level one heading tag h1 if there's no requirement then set the font size to 0 to avoid accessibility issues.

I hope it adds to your learning, happy coding :)

Marked as helpful

1

Alex 100

@Alex6pc

Posted

@iprinceroyy Hello Prince, thank you for your help.

What exacly do you mean with the "You can use CSS latest functions min(), max(), and clamp() for responsive fonts, margin, padding, and width"?

where can i find more info for these?

Alex

0
Prince Roy 1,210

@iprinceroyy

Posted

@Alex6pc Here

Marked as helpful

1
Alex 100

@Alex6pc

Posted

@iprinceroyy Thank you mate

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord