base-apparel-coming-soon

Please log in to post a comment
Log in with GitHubCommunity feedback
- @0xabdulkhaliq
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
COMPONENT MEASUREMENTS 📐:
- The
min-width: 100vw
property formain
is not necessary. because it's a block level element which will take the full width of the page by default.
- So feel free to remove
min-width: 100vw
style rule frommain
this will help you to write efficient code and makes your code more reusable.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful - @NehalSahu8055
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions to improve your design.
- It would be better if you give some breakpoint below
900px
because on my desktop screen mobile version is visible.
@media (max-width: 900px) or @media (max-width: 57rem)
- Always use
responsive units
(rem,em or %)
, try to explore more specific usecase of each on google.
I hope you find this helpful. Above all, the solution you submitted is great !
Happy coding😄
Marked as helpful - It would be better if you give some breakpoint below
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord