Skip to content
Submitted over 4 years ago

base-apparel-coming-soon with vanilla Js, and basic html-css

Iqbal•135
@Firdausi-Iqbal
A solution to the Base Apparel coming soon page challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Challenge accepted!

learning basic JS for couple of days in order to finish this challenge. if you have suggestions on how i can improve, feel free to give your feedback. Thanks 😁

Code
Couldn’t fetch repository

Please log in to post a comment

Log in

Community feedback

  • Boyan Liu•465
    @BoyanLiuu

    Hello , Iqbal Everything looks good to me , but I would like to give some suggestion for the css part. I notice that you are using rem , which is nice. I am suggesting you can set font-size:62.5% in the root. It would turn default 16 px into 10 px which you could easily do the math in the future. Another one is You can add box-sizing: border-box; in the root element as well. It guarantees that the content box shrinks to make space for the padding and borders. Therefore, if you set your element width to 200 pixels, border-box makes sure that the content, padding, and borders fit in this number

    https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing

    Happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord