Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

basic as heck solution

jake 140

@jakewebd

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


roast me :/ but constructively. I've been learning only for about a week give or take.

Community feedback

@J0SEED01

Posted

Hola que tal dejo algunas recomendaciones.

Primero que nada los estilos van en un archivo aparte, te creas una carpeta css y dentro el archivo style.css y ese lo linkeas en el HTML <link rel="stylesheet" href="style.css"> ES UNA PESIMA PRACTICA PONER LOS ESTILOS EN EL DOCUMENTO HTML! y otra recomendacion es que los estilos se dan con clases y no con ID en vez de poner ID poner class osea id="main-container" escribir class="main-container" y en el CSS quedaria asi .main-container{ background-color:rgba(255,255,255,1); width:200px; height:320px; position:absolute; left:42%; top:30%; border-radius:5%; box-shadow:2px 2px rgba(0,0,0,0.1); } y lo otro es que la etiqueta HTML siempre va antes del BODY, te recomiendo aprender bien HTML Y CSS (flexbox y grid) eso por el momento.

Saludos!

1

jake 140

@jakewebd

Posted

@J0SEED01 yea it was a little bit of laziness not having the css seperated. i didnt really see a point to using classes as i didnt have any repeating styles i needed to use but i guess its better practice yo use them eh? thanks for the tips though!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord