Basic css

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted about 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Flexbox to center the component

  body {
    margin: 0;
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  body {
    width: 1440px;
    max-width: 1440px;
    padding-top: 180px;
    padding-bottom: 120px;
    margin: 0 auto;
  }
  

  • The max-width: 1440px property for body element is not necessary and it may cause overflow issues on smaller devices with smaller screens. And it's a block level element also so it will take the full width of the page by default.

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  00
• 

  Manish Patel•740

  @savvystrider

  Posted about 2 years ago

  Looks great! The only thing I would recommend is adding some transitions to the hover effects/active states.

  00